Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve browserslist declaration #1525

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

pauldambra
Copy link
Member

This was missed in the ES6 switcheroo

We then will also add IE11 for a specific bundle here

targets: es5
? '>0.5%, last 2 versions, Firefox ESR, not dead, IE 11'
: '>0.5%, last 2 versions, Firefox ESR, not dead',
},

Changes

...

Checklist

  • Tests for new code (see advice on the tests we use)
  • Accounted for the impact of any changes across different browsers
  • Accounted for backwards compatibility of any changes (no breaking changes in posthog-js!)

Copy link

vercel bot commented Nov 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog-js ✅ Ready (Inspect) Visit Preview Nov 15, 2024 11:57pm

Copy link

github-actions bot commented Nov 14, 2024

Size Change: +17 kB (+0.55%)

Total Size: 3.13 MB

Filename Size Change
dist/all-external-dependencies.js 205 kB +1.47 kB (+0.72%)
dist/array.full.js 357 kB +1.32 kB (+0.37%)
dist/array.full.no-external.js 356 kB +1.29 kB (+0.36%)
dist/array.js 172 kB +895 B (+0.52%)
dist/array.no-external.js 171 kB +871 B (+0.51%)
dist/dead-clicks-autocapture.js 13.7 kB +719 B (+5.54%) 🔍
dist/exception-autocapture.js 9.46 kB +657 B (+7.46%) 🔍
dist/external-scripts-loader.js 2.22 kB +28 B (+1.28%)
dist/main.js 172 kB +911 B (+0.53%)
dist/module.full.js 357 kB +1.32 kB (+0.37%)
dist/module.full.no-external.js 356 kB +1.29 kB (+0.36%)
dist/module.js 172 kB +911 B (+0.53%)
dist/module.no-external.js 171 kB +889 B (+0.52%)
dist/recorder-v2.js 114 kB +1.08 kB (+0.96%)
dist/recorder.js 115 kB +1.08 kB (+0.96%)
dist/surveys-preview.js 57.6 kB +911 B (+1.61%)
dist/surveys.js 63.1 kB +1.03 kB (+1.65%)
dist/tracing-headers.js 1.68 kB +354 B (+26.64%) 🚨
dist/web-vitals.js 10.3 kB -8 B (-0.08%)
ℹ️ View Unchanged
Filename Size
dist/array.full.es5.js 254 kB

compressed-size-action

@pauldambra
Copy link
Member Author

oh, very interesting that makes tests fail 🤯

@pauldambra pauldambra changed the title chore: remove IE11 from main browserlist declaration fix: improve browserslist declaration Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants