fix: XHR req method capture #1527
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -280,6 +280,62 @@ describe('Session recording', () => { | |||
| ) | |||
| }) | |||
| }) | |||
|
|
|||
| it('it captures XHR method correctly', () => { | |||
There was a problem hiding this comment.
these tests have a lot of duplication now, but I want to get this fix out
There was a problem hiding this comment.
This test is pretty convincing, how would it have failed before?
There was a problem hiding this comment.
The method = POST assertion?
There was a problem hiding this comment.
yep... it was always GET before (or at least overwhelmingly GET I didn't check which)
There was a problem hiding this comment.
and for clarity I validated the test failed before the change 😊
| @@ -386,7 +386,7 @@ function prepareRequest({ | |||
| timeOrigin, | |||
| timestamp, | |||
| method: method, | |||
| initiatorType: entry ? (entry.initiatorType as InitiatorType) : initiatorType, | |||
There was a problem hiding this comment.
flips the choice here... if we're providing an initiator we should use it in preference to the detected one
they should always match
| @@ -309,7 +309,7 @@ function initXhrObserver(cb: networkCallback, win: IWindow, options: Required<Ne | |||
| .then((entry) => { | |||
| const requests = prepareRequest({ | |||
| entry, | |||
| method: req.method, | |||
| method: method, | |||
There was a problem hiding this comment.
this is the fix... the method is provided to the XHR function when it is called so we should use it
|
Size Change: +21 B (0%) Total Size: 3.11 MB
ℹ️ View Unchanged
|
We were using
req.methodbefore the request was used and so XHR was always captured as "GET"