fix(surveys): multiple choice survey submit button bug #822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think I'm going to add some more tests... but let's get this in ASAP first... |
|
Size Change: -2 B (0%) Total Size: 726 kB
ℹ️ View Unchanged
|
neilkakkar
reviewed
Oct 4, 2023
src/extensions/surveys.ts
Outdated
| @@ -635,7 +635,7 @@ export const createMultipleChoicePopup = (posthog: PostHog, survey: Survey, ques | |||
| : formElement.querySelectorAll('input[type=checkbox]:checked') | |||
| // eslint-disable-next-line @typescript-eslint/ban-ts-comment | |||
| // @ts-ignore // TODO: Fix this, error because it doesn't recognize node list as an array | |||
| if (selectedChoices && (selectedChoices.length ?? 0) > 0) { | |||
| if ((singleOrMultiSelect === 'single_choice' && selectedChoices) || (selectedChoices.length ?? 0) > 0) { | |||
There was a problem hiding this comment.
any reason not to use querySelectorAll above for single choice as well?
There was a problem hiding this comment.
THAT MAKES A LOT OF SENSE
There was a problem hiding this comment.
wait i'm going to test it real quick locally first though
neilkakkar
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Single choice surveys could not be submitted bug
Regular
querySelectorhere returns element instead of a list of elements so we should not check.lengthon itChecklist