Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow window to be truly undefined #895

Merged
merged 5 commits into from
Nov 15, 2023

Conversation

benjackwhite
Copy link
Collaborator

Changes

Follow up to #894 makes window and document actually maybe undefined so that we can check the types correctly instead of casting

Checklist

Copy link

github-actions bot commented Nov 15, 2023

Size Change: +3.85 kB (+1%)

Total Size: 739 kB

Filename Size Change
dist/array.full.js 175 kB +978 B (+1%)
dist/array.js 117 kB +899 B (+1%)
dist/es.js 117 kB +899 B (+1%)
dist/exception-autocapture.js 12 kB +56 B (0%)
dist/module.js 117 kB +899 B (+1%)
dist/recorder-v2.js 104 kB +46 B (0%)
dist/recorder.js 58.4 kB +30 B (0%)
dist/surveys.js 39.9 kB +43 B (0%)

compressed-size-action

# Conflicts:
#	src/extensions/toolbar.ts
#	src/storage.ts
#	src/utils/globals.ts
#	src/utils/logger.ts
@benjackwhite benjackwhite changed the base branch from master to fix/window-access November 15, 2023 09:11
@benjackwhite benjackwhite marked this pull request as ready for review November 15, 2023 10:26
@benjackwhite benjackwhite merged commit 4d23f2d into fix/window-access Nov 15, 2023
11 checks passed
@benjackwhite benjackwhite deleted the fix/window-access-proper branch November 15, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant