fix: Fix unit tests #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They had hard-coded version number expectations which failed the tests when the version was incremented. This commit changes the tests to use the VERSION constant for the expectations.
There was a problem hiding this comment.
Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.
Files not reviewed (2)
- test/FeatureFlagTest.php: Language not supported
- test/PostHogTest.php: Language not supported
Comments suppressed due to low confidence (1)
README.md:16
- Ensure that the bin/test script has the correct executable permissions or add a note in the documentation about setting them, to avoid issues when running tests.
3. `bin/test` to run tests (this script calls `./vendor/bin/phpunit --verbose test`)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several tests were failing. They had hard-coded version number expectations which failed the tests when the version was incremented.
This PR changes the tests to use the VERSION constant for the expectations.
Also added a bin/test script to run tests