fix: python release attempt 3 #242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pauldambra
commented
Jun 5, 2025
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR addresses failing release actions by modernizing Python package configuration and removing deprecated license classifiers.
- Consolidates configuration by migrating from
setup.cfgtopyproject.tomlfollowing modern Python packaging standards - Removes deprecated
License :: OSI Approved :: MIT Licenseclassifier fromsetup.pyandsetup_analytics.pywhile maintaining license declarations - Updates build settings in
pyproject.tomlwith standardized line length configurations and pytest async testing support - Keep an eye on package discoverability on PyPI without the license classifier
4 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
pauldambra
commented
Jun 5, 2025
| @@ -97,7 +97,6 @@ | |||
| classifiers=[ | |||
| "Development Status :: 5 - Production/Stable", | |||
| "Intended Audience :: Developers", | |||
| "License :: OSI Approved :: MIT License", | |||
There was a problem hiding this comment.
i think maybe this is deprecated, let's move the license note to pyproject.toml and see if that helps
oliverb123
approved these changes
Jun 5, 2025
pauldambra
changed the title
oliverb123
force-pushed
the
fix/release-try-2
branch
from
097588e to
c9bd525
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the release action is still failing https://github.com/PostHog/posthog-python/actions/runs/15468256593/job/43545576349
i can't run it locally
so, let's try this