fix(paths): gracefully handle nulls for local cleaning filters #26085
+27
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Duplicating an insight leads to
null
s in the query. For the local path cleaning filters this resulted in a crash for a customer.Changes
Gracefully handles
null
values for the local path cleaning filter.Follow-ups
Look into wether duplicating an insight creates these-> could not reproducenull
s, and if so - fix thatnull
andundefined
, meaning we have no protection from "faulty" queries like this in our backend side validation. Likely we should addnull
s to the wholeschema.ts
types where we have an optional value.How did you test this code?
Used the query from the customer locally to verify the issue and fix.