Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(max): Rename some things for a clearer agent architecture #26154

Merged
merged 4 commits into from
Nov 12, 2024

Conversation

Twixes
Copy link
Collaborator

@Twixes Twixes commented Nov 12, 2024

Changes

A few refactoring changes to make AI agent development more intuitive:

  • Renamed _reconstruct_conversation to _construct_messages
  • Capitalized global constants like REACT_SYSTEM_PROMPT
  • Rename _run() methods on AssistantNode subclasses to be clearly differentiated from run(), like _run_with_prompt()
  • Renamed TestGeneratorNode to prevent pytest confusion (pytest considers every class starting with Test to be a test suite)

No functional changes.

@Twixes Twixes requested a review from skoob13 November 12, 2024 15:55
@Twixes Twixes merged commit 7b0e906 into master Nov 12, 2024
90 checks passed
@Twixes Twixes deleted the max-refactor-conversation branch November 12, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants