feat(err): Rewrite main, improve error handling, more metrics #26155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does what it says on the tin. I want to know more about how long various stages of symbol set processing take, and I want to be able to run the code locally under something like
perfto profile it and work on hotspots. If we deploy this, I think it'll make cymbal restart much more often, since I've removed the crutch of reporting liveness every frame resolve, but I'm not certain. I kind of suspect the occasional restarts were due to ourreqwestclient not having a low enough timeout, but these metrics should help me say for sure.Basically, cymbal lives, now lets make it more fragile so we can then make it more robust