Skip to content

chore: remove sidebar in onboarding#29846

Merged
joshsny merged 22 commits intomasterfrom
no-sidebar-in-onboarding
Apr 17, 2025
Merged

chore: remove sidebar in onboarding#29846
joshsny merged 22 commits intomasterfrom
no-sidebar-in-onboarding

Conversation

@joshsny
Copy link
Contributor

@joshsny joshsny commented Mar 12, 2025

Problem

From looking at recordings, users get very distracted during the onboarding flow by the sidebar and all the products there

Changes

  • Remove the sidebar on the products and onboarding flow to make things less complicated
  • Fix dark mode on plain pages
Screenshot 2025-03-12 at 18 21 45

Does this work well for both Cloud and self-hosted?

Yes

How did you test this code?

Ran it locally

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR removes the sidebar during onboarding flows to reduce user distraction, while also fixing dark mode behavior on plain pages and improving layout consistency.

  • Modified frontend/src/scenes/scenes.ts to use layout: 'plain' for Products and Onboarding scenes instead of previous app-raw layout
  • Added height constraint (h-full) in frontend/src/scenes/products/Products.tsx for proper vertical centering
  • Simplified dark mode logic in themeLogic.ts by removing sceneConfig?.layout === 'plain' condition
  • Replaced BridgePage component with direct flexbox styling in Wizard.tsx for cleaner layout
  • Added padding classes in Onboarding.tsx to compensate for sidebar removal while maintaining proper spacing

6 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@joshsny joshsny requested a review from a team March 12, 2025 18:23
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

20 snapshot changes in total. 0 added, 20 modified, 0 deleted:

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 12, 2025

Size Change: -114 B (0%)

Total Size: 13.6 MB

ℹ️ View Unchanged
Filename Size Change
frontend/dist/toolbar.js 13.6 MB -114 B (0%)

compressed-size-action

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

4 snapshot changes in total. 0 added, 4 modified, 0 deleted:

  • chromium: 0 added, 0 modified, 0 deleted
  • webkit: 0 added, 4 modified, 0 deleted (diff for shard 2)

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

4 snapshot changes in total. 0 added, 4 modified, 0 deleted:

  • chromium: 0 added, 0 modified, 0 deleted
  • webkit: 0 added, 4 modified, 0 deleted (diff for shard 2)

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

4 snapshot changes in total. 0 added, 4 modified, 0 deleted:

  • chromium: 0 added, 0 modified, 0 deleted
  • webkit: 0 added, 4 modified, 0 deleted (diff for shard 2)

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

Copy link
Contributor

@zlwaterfield zlwaterfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great change but I wanted to note that we did have something like this in the past and users were annoyed they were "blocked". Is there a way to run this as experiment? Or are you just going to watch the metrics and replays closely after merging?

@joshsny
Copy link
Contributor Author

joshsny commented Mar 17, 2025

This is a great change but I wanted to note that we did have something like this in the past and users were annoyed they were "blocked". Is there a way to run this as experiment? Or are you just going to watch the metrics and replays closely after merging?

Yeah going to stare at replays for a long time to make sure users don't hate it and quit, if they do, we can trial a "skip onboarding" button - but I'd rather avoid that for now to see if this encourages users to just stick to the intended onboarding flow.

This is particularly important for additional projects in an org, where it's annoying to go through things again.

@joshsny joshsny enabled auto-merge (squash) March 18, 2025 11:32
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@joshsny joshsny disabled auto-merge March 18, 2025 12:33
@posthog-bot
Copy link
Contributor

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week. If you want to permanentely keep it open, use the waiting label.

@posthog-bot
Copy link
Contributor

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week. If you want to permanentely keep it open, use the waiting label.

@joshsny joshsny removed the stale label Apr 3, 2025
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week. If you want to permanentely keep it open, use the waiting label.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

4 snapshot changes in total. 0 added, 4 modified, 0 deleted:

  • chromium: 0 added, 4 modified, 0 deleted (diff for shard 4)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@joshsny joshsny merged commit 3a284e8 into master Apr 17, 2025
97 of 110 checks passed
@joshsny joshsny deleted the no-sidebar-in-onboarding branch April 17, 2025 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants