chore: remove sidebar in onboarding#29846
Conversation
There was a problem hiding this comment.
PR Summary
This PR removes the sidebar during onboarding flows to reduce user distraction, while also fixing dark mode behavior on plain pages and improving layout consistency.
- Modified
frontend/src/scenes/scenes.tsto uselayout: 'plain'for Products and Onboarding scenes instead of previous app-raw layout - Added height constraint (
h-full) infrontend/src/scenes/products/Products.tsxfor proper vertical centering - Simplified dark mode logic in
themeLogic.tsby removingsceneConfig?.layout === 'plain'condition - Replaced
BridgePagecomponent with direct flexbox styling inWizard.tsxfor cleaner layout - Added padding classes in
Onboarding.tsxto compensate for sidebar removal while maintaining proper spacing
6 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
📸 UI snapshots have been updated20 snapshot changes in total. 0 added, 20 modified, 0 deleted:
Triggered by this commit. |
|
Size Change: -114 B (0%) Total Size: 13.6 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated4 snapshot changes in total. 0 added, 4 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated4 snapshot changes in total. 0 added, 4 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated4 snapshot changes in total. 0 added, 4 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
zlwaterfield
left a comment
There was a problem hiding this comment.
This is a great change but I wanted to note that we did have something like this in the past and users were annoyed they were "blocked". Is there a way to run this as experiment? Or are you just going to watch the metrics and replays closely after merging?
Yeah going to stare at replays for a long time to make sure users don't hate it and quit, if they do, we can trial a "skip onboarding" button - but I'd rather avoid that for now to see if this encourages users to just stick to the intended onboarding flow. This is particularly important for additional projects in an org, where it's annoying to go through things again. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
|
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
|
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
|
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
📸 UI snapshots have been updated4 snapshot changes in total. 0 added, 4 modified, 0 deleted:
Triggered by this commit. |
Problem
From looking at recordings, users get very distracted during the onboarding flow by the sidebar and all the products there
Changes
Does this work well for both Cloud and self-hosted?
Yes
How did you test this code?
Ran it locally