PGM-IO internal import resolution: Copy is_nan functionality from PGM, Step 4#299
Merged
nitbharambe merged 6 commits intomainfrom May 15, 2025
Merged
PGM-IO internal import resolution: Copy is_nan functionality from PGM, Step 4#299nitbharambe merged 6 commits intomainfrom
nitbharambe merged 6 commits intomainfrom
Conversation
Signed-off-by: Nitish Bharambe <[email protected]>
Signed-off-by: Nitish Bharambe <[email protected]>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR embeds the is_nan logic into the JSON converter (instead of importing from power_grid_model), updates dataset serialization to use the new method, and adds unit tests for the new functionality.
- Removed external
is_nanimport and added an internal_is_nanstatic method - Updated
_serialize_datasetto callself._is_nan - Added
test_is_nanto verify behavior across float and integer arrays
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tests/unit/converters/test_pgm_json_converter.py | Added test_is_nan to cover float and integer cases |
| src/power_grid_model_io/converters/pgm_json_converter.py | Removed external import, added internal _is_nan and adjusted serialization |
Co-authored-by: Copilot <[email protected]> Co-authored-by: Jerry Guo <[email protected]> Signed-off-by: Nitish Bharambe <[email protected]>
Co-authored-by: Jerry Guo <[email protected]> Signed-off-by: Nitish Bharambe <[email protected]>
Signed-off-by: Nitish Bharambe <[email protected]>
|
Jerry-Jinfeng-Guo
approved these changes
May 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue: #297
The alternative to Step 4, of copying the is_nan functionality is done. Since this is implemented, we can skip step 2