Skip to content

PGM-IO internal import resolution: Move isnan back to internal import, step 3 #989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nitbharambe
Copy link
Member

Fixes issue:
PowerGridModel/power-grid-model-io#297
Step 3 of "verbose robust resolution" mentioned in this issue solution.

To be merged at PGM v1.11 (#976)

This reverts commit 02d9904.

Signed-off-by: Nitish Bharambe <[email protected]>
Copy link

sonarqubecloud bot commented May 8, 2025

@nitbharambe nitbharambe marked this pull request as ready for review May 8, 2025 14:02
petersalemink95
petersalemink95 previously approved these changes May 8, 2025
Copy link
Member

@petersalemink95 petersalemink95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already approve - should not be merged until version bump

Base automatically changed from fix/re-add-internal-is-nan-util to main May 8, 2025 15:05
@nitbharambe nitbharambe dismissed petersalemink95’s stale review May 8, 2025 15:05

The base branch was changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge This should not be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants