-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Instrument task runs #15955
Open
jeanluciano
wants to merge
14
commits into
main
Choose a base branch
from
jean/cloud-565-task-run-instrumentation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Instrument task runs #15955
+304
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
upstream dependency
An upstream issue caused by a bug in one of our dependencies
label
Nov 8, 2024
CodSpeed Performance ReportMerging #15955 will not alter performanceComparing Summary
|
…/cloud-565-task-run-instrumentation
jeanluciano
requested review from
cicdw,
desertaxle and
zzstoatzz
as code owners
November 14, 2024 17:45
cicdw
requested changes
Nov 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few changes that stood out to me; still need to review more closely
…/cloud-565-task-run-instrumentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds OTEL instrumentation into the task engine so that if a user were to configure application-level telemetry, the task run engine will now emit spans for runs that capture metadata about the task run in span attributes and state changes as events on the span.
What impact will this have if I do not have telemetry configured?
https://opentelemetry.io/docs/concepts/instrumentation/libraries/#performance
Performance
OpenTelemetry API is no-op and very performant when there is no SDK in the application
This PR also sets up some testing infrastructure for testing otel instrumentation implemented by @collincchoy in #16010
Checklist
<link to issue>
"mint.json
.