Skip to content

Conversation

cwentland0
Copy link
Collaborator

Implements a 2D Burgers' case which features homogeneous Dirichlet BCs on the bottom and left boundaries, and homogeneous Neumann BCs on the top and right boundaries. This allows the Gaussian pulse IC to advect out of the domain, rather than following the previously-fixed periodic BCs. This case is largely just to simplify the Schwarz work, but also makes the 2D Burgers' case more generic. Also, this PR:

  • Updates the problem constructors to follow the more generic "create_problem_eigen" format
  • Adds the more generic problem parameterization that has been implemented for 2D Euler and 2D SWE
  • Adds all necessary mechanisms for 2D Burgers Schwarz coupling
  • Adds relevant tests for new case

@cwentland0 cwentland0 requested a review from fnrizzi January 24, 2025 20:25
@cwentland0 cwentland0 marked this pull request as draft January 24, 2025 21:22
@cwentland0 cwentland0 marked this pull request as ready for review January 27, 2025 16:36
Copy link
Member

@fnrizzi fnrizzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a lot of changes but ci passes so i thnik we are ok

@fnrizzi fnrizzi merged commit 4a783de into develop Feb 25, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants