Skip to content
This repository was archived by the owner on Dec 1, 2020. It is now read-only.

[*] Project : refactoring all javascript s code about the module blockcart #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

timsit
Copy link

@timsit timsit commented Oct 24, 2014

Update: Solved merge issue of this one PrestaShop/PrestaShop#1829

Ok this is a big one.

It's a first step but really necessary. All the website I had to do with prestashop, the blockcart is allways the longer and the hardest part to integrate. Even if you want to just override the javascript from the template you have to read all the javascrpti code to copy past only the needed part and remove all the template-related interraction.

So the main idea here is to begin by separate the data part (ajax-cart.js) and the interaction part (blockcart.js). I also made a huge effort into the comment part for the ajax-cart.js functions.

With that you will just need to override the blockcart.js file and call the function from the ajax-cart.js. You don't need to go through a dirty javascript file to pull out the data call in way to interact with your custom template !

Every input is very welcome because for me the cart part of every shop I made is a least 30% of the time I past in the template part of a Prestashop.

Hope you will enjoy and contribute and sorry for my poor English ;)

@timsit
Copy link
Author

timsit commented Oct 24, 2014

New pull request because of the submodule system

#1
PrestaShop/blocklayered#31
PrestaShop/blocksearch#1

This one should be considere too but I don't know why I can't make a pull request from it :
timsit/PrestaShop@fff300c

@timsit
Copy link
Author

timsit commented Dec 10, 2014

@gRoussac @rGaillard Is somebody in charge of this module ?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant