Skip to content

add sampling paramters like in the R1 model card #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 30, 2025
Merged

add sampling paramters like in the R1 model card #21

merged 6 commits into from
Jan 30, 2025

Conversation

felix-red-panda
Copy link
Contributor

No description provided.

samsja
samsja reviewed Jan 30, 2025
View reviewed changes
samsja
samsja requested changes Jan 30, 2025
View reviewed changes
Copy link
Member

@samsja samsja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to repeat it in the config if we change the default value in the code

@samsja samsja merged commit 8c4484f into main Jan 30, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsja samsja samsja approved these changes

@justusmattern27 justusmattern27 Awaiting requested review from justusmattern27

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@felix-red-panda @samsja