Skip to content

Feature: Ability to watch prime pods list change in real-time #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2025

Conversation

JannikSt
Copy link
Member

@JannikSt JannikSt commented Apr 4, 2025

No description provided.

@JannikSt JannikSt requested a review from Copilot April 4, 2025 11:40
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

src/prime_cli/commands/pods.py:126

  • [nitpick] The condition here is redundant given that the outer 'if' block already handles hash changes. Simplify the logic to improve clarity and avoid potential unintended behavior in watch mode.
if current_pods_hash != last_pods_hash or last_pods_hash is None:

@JannikSt JannikSt merged commit d4e5e1f into main Apr 4, 2025
2 checks passed
@JannikSt JannikSt deleted the improvement/watch-pods-list branch April 4, 2025 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants