Skip to content

Feature: simple login to prime #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 8, 2025
Merged

Feature: simple login to prime #35

merged 3 commits into from
May 8, 2025

Conversation

JannikSt
Copy link
Member

@JannikSt JannikSt commented May 8, 2025

No description provided.

@JannikSt JannikSt requested a review from Copilot May 8, 2025 06:55
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a simple login feature to Prime via the CLI while also enhancing the pods command with a retry mechanism for SSH connection availability. Key changes include:

  • Registration of a new login command in the CLI main entry point.
  • Implementation of a new login module (login.py) that handles RSA keypair generation and challenge-based authentication.
  • Update to the pods command to wait (in a loop) for the SSH connection to become available.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
src/prime_cli/main.py Registers the new login command.
src/prime_cli/commands/pods.py Implements a retry loop for establishing an SSH connection.
src/prime_cli/commands/login.py Adds login functionality using challenge-response authentication.

@JannikSt JannikSt merged commit f8ce180 into main May 8, 2025
2 checks passed
@JannikSt JannikSt deleted the feature/simple-login branch May 8, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants