wraped in try except #38
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution! :) |
There was a problem hiding this comment.
Pull Request Overview
This PR improves error handling for interactive prompts by wrapping various user input sections in try/except blocks to catch cancellation events.
- Added a top-level try block around the pod creation logic for API error handling.
- Introduced try/except blocks for GPU selection, provider selection, configuration selection, pod name, disk size, vCPU, memory, image, and team ID prompts.
- Wrapped the final pod creation confirmation to handle cancellation gracefully.
Comment on lines
+347
to
+371
| try: | ||
| # Show available GPU types | ||
| console.print("\n[bold]Available GPU Types:[/bold]") | ||
| gpu_types = sorted( | ||
| [ | ||
| gpu_type | ||
| for gpu_type, gpus in availabilities.items() | ||
| if len(gpus) > 0 | ||
| ] | ||
| ) | ||
| for idx, gpu_type_option in enumerate(gpu_types, 1): | ||
| console.print(f"{idx}. {gpu_type_option}") | ||
|
|
||
| gpu_type_idx = typer.prompt("Select GPU type number", type=int, default=1) | ||
| if gpu_type_idx < 1 or gpu_type_idx > len(gpu_types): | ||
| console.print("[red]Invalid GPU type selection[/red]") | ||
| raise typer.Exit(1) | ||
| gpu_type = gpu_types[gpu_type_idx - 1] | ||
| gpu_type_idx = typer.prompt( | ||
| "Select GPU type number", type=int, default=1 | ||
| ) | ||
| if gpu_type_idx < 1 or gpu_type_idx > len(gpu_types): | ||
| console.print("[red]Invalid GPU type selection[/red]") | ||
| raise typer.Exit(1) | ||
| gpu_type = gpu_types[gpu_type_idx - 1] | ||
| except (KeyboardInterrupt, typer.Abort): | ||
| console.print( | ||
| "\n[yellow]GPU type selection cancelled by user[/yellow]" | ||
| ) | ||
| raise typer.Exit(0) |
There was a problem hiding this comment.
Multiple similar try/except blocks for handling interactive prompt cancellations are used throughout the function. Consider extracting a helper function for prompt interactions and cancellation to reduce duplicate code and improve maintainability.
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #34
i tried wrapping everything in try except for abort error handling if there is any better approach you think i should take please let me know : )