Skip to content

fix 7b #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

fix 7b #381

wants to merge 7 commits into from

Conversation

samsja
Copy link
Member

@samsja samsja commented Jun 10, 2025

No description provided.

@samsja samsja marked this pull request as ready for review June 11, 2025 02:45
@samsja samsja requested a review from justusmattern27 June 11, 2025 02:45
justusmattern27
justusmattern27 approved these changes Jun 11, 2025
View reviewed changes
configs/inference/stability_ablation/math_only_7b.toml Outdated
min_solve_rate = 0.1
max_solve_rate = 0.9
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is probably too high, would go for something between 0.5 and 0.7

@mikasenghaas
Copy link
Collaborator

this will have merge conflicts with config refactor too, but should be easy to resolve/ maybe even open new pr with changes after the config refactor is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justusmattern27 justusmattern27 justusmattern27 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samsja @mikasenghaas @justusmattern27