Refactor: use shared dependencies across crates #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JannikSt
requested changes
Mar 20, 2025
Cargo.toml
Outdated
| clap = { version = "4.5.27", features = ["derive"] } | ||
| serde = { version = "1.0", features = ["derive"] } | ||
| tokio = { version = "1.43.0", features = ["full"] } | ||
| uuid = { version = "1.5", features = ["v4", "serde"] } |
There was a problem hiding this comment.
Suggested change
| uuid = { version = "1.5", features = ["v4", "serde"] } | |
| uuid = { version = "1.12.1", features = ["v4", "serde"] } |
Cargo.toml
Outdated
| shared = { path = "shared" } | ||
| actix-web = "4.9.0" | ||
| clap = { version = "4.5.27", features = ["derive"] } | ||
| serde = { version = "1.0", features = ["derive"] } |
There was a problem hiding this comment.
Suggested change
| serde = { version = "1.0", features = ["derive"] } | |
| serde = { version = "1.0.219", features = ["derive"] } |
gsegatti
force-pushed
the
refac/deps
branch
2 times, most recently
from
b655abe to
143bf24
Compare
All done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all, first PR around here, tackling some of the low hanging fruit.
Leaving it on draft in case there's any preliminary reviews before I get the full env working and fully run cargo test (granted it does compile and that is mostly what is relevant for this pr). Clippy and fmt applied.