Skip to content

Conversation

@JannikSt
Copy link
Member

No description provided.

@JannikSt JannikSt requested a review from Copilot June 19, 2025 03:20
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR standardizes Ether amount formatting by replacing manual wei-to-ether conversions with the format_ether utility across provider operations, CLI commands, and an example.

  • Imported and used format_ether in place of manual division by 10^18.
  • Cleaned up various Console::info and println! calls for consistency.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
crates/worker/src/operations/provider.rs Replaced manual wei division with format_ether in log messages.
crates/worker/src/cli/command.rs Switched CLI output to use format_ether, added import and calls.
crates/dev-utils/examples/transfer_eth.rs Updated example to format balances via format_ether.
Comments suppressed due to low confidence (2)

crates/worker/src/operations/provider.rs:226

  • [nitpick] The label "Balance" is ambiguous in the context of both token and ETH balances; consider making it more specific (e.g., "Token balance").
            Console::info("Balance", &format_ether(balance));

crates/worker/src/operations/provider.rs:274

  • [nitpick] This duplicate log also uses the generic label "Balance"; renaming it to distinguish token balance from ETH balance would improve clarity.
            Console::info("Balance", &format_ether(balance));

@JannikSt JannikSt force-pushed the fix/eth-formatting branch from b8afd5f to 9c5133d Compare June 29, 2025 10:07
@JannikSt JannikSt merged commit 0ad0e5c into develop Jun 29, 2025
1 check passed
@JannikSt JannikSt deleted the fix/eth-formatting branch June 29, 2025 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants