Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 461 -- Implement Parameter Reader #462

Merged
merged 2 commits into from
Feb 14, 2025
Merged

Issue 461 -- Implement Parameter Reader #462

merged 2 commits into from
Feb 14, 2025

Conversation

lsawade
Copy link
Collaborator

@lsawade lsawade commented Feb 10, 2025

Description

Implements the reader for the mesh_parameters.bin file

I also implemented a first CMake preset that we can add on to (#450). I will probably add the remaining presets in the next PR. As a result you now can

You can now configure a serial debug version using

cmake --preset debug && cmake --build --preset debug

This will build in the build/debug directory, so to access specfem2d, you have to

export PATH="path/to/SPECFEMPP/build/debug/bin/":$PATH

IMPORTANT: This of course breaks the tests since the tests are built with relative directory locations. We need to add working directories for the tests in ./tests/CMakeLists.txt.

Issue Number

Closes #461, partially addresses #450 .

Checklist

Please make sure to check developer documentation on specfem docs.

  • I ran the code through pre-commit to check style
  • My code passes all the integration tests
  • I have added sufficient unittests to test my changes
  • I have added/updated documentation for the changes I am proposing
  • I have updated CMakeLists to ensure my code builds
  • My code builds across all platforms

@lsawade lsawade changed the base branch from main to issue-390 February 10, 2025 17:35
@lsawade lsawade requested a review from icui February 10, 2025 17:41
@lsawade
Copy link
Collaborator Author

lsawade commented Feb 10, 2025

The tests that are failing are remnants from me trying to merge into main, and do not contain the OpenMP fix.

@lsawade lsawade merged commit e740972 into issue-390 Feb 14, 2025
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement a mesh_parameters.bin reader and populate mesh::parameters<dim3> struct
2 participants