Skip to content

Conversation

lsawade
Copy link
Collaborator

@lsawade lsawade commented Feb 14, 2025

Description

Implementation of the 3D mesh reader, and associated updates to the codebase.

Main tracking branch: Branch issue-390

PRs

New implementations

Restructure

Issue Number

For the related issues, please see the PRs

Checklist

Please make sure to check developer documentation on specfem docs.

  • I ran the code through pre-commit to check style
  • My code passes all the integration tests
  • I have added sufficient unittests to test my changes
  • I have added/updated documentation for the changes I am proposing
  • I have updated CMakeLists to ensure my code builds
  • My code builds across all platforms

Rohit-Kakodkar and others added 30 commits January 14, 2025 11:08
Updated the save_database function to write element by element
Make the directory structure for 3D mesher flexible
Separate mesher and generate databases par file
Issue 455 - Refactor IO/mesh/impl/fortran -> IO/mesh/impl/fortran/dim2 & create barebone specfem3d.cpp
Issue 457 -- Implement Meshfem Parameter writer
…h etc. are now being configured in the build directory, keeping the src directory clean.
@lsawade lsawade requested review from Rohit-Kakodkar and icui and removed request for Rohit-Kakodkar and icui March 4, 2025 14:24
@lsawade lsawade mentioned this pull request Mar 4, 2025
6 tasks
@lsawade lsawade requested review from Rohit-Kakodkar and icui March 6, 2025 16:45
@lsawade
Copy link
Collaborator Author

lsawade commented Mar 6, 2025

ooof I see there are conflict nowwwwww

@lsawade
Copy link
Collaborator Author

lsawade commented Mar 10, 2025

Yay!!!

@lsawade lsawade requested review from Rohit-Kakodkar and icui March 10, 2025 20:36
Copy link
Collaborator

@Rohit-Kakodkar Rohit-Kakodkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! Assuming I saw all previous PRs

@lsawade lsawade merged commit f3e96c5 into devel Mar 11, 2025
6 checks passed
@lsawade lsawade added enhancement New feature or request 3D labels Jun 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants