-
Notifications
You must be signed in to change notification settings - Fork 17
[MAIN PR] Read the 3D Mesh (Issue #390) #476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the save_database function to write element by element
Make the directory structure for 3D mesher flexible
Separate mesher and generate databases par file
…O/mesh/impl/fortran/dim2
Issue 455 - Refactor IO/mesh/impl/fortran -> IO/mesh/impl/fortran/dim2 & create barebone specfem3d.cpp
Issue 457 -- Implement Meshfem Parameter writer
…cfem_setup.hpp also a configuration file
… of constants.h and specfem_setup.hpp
…h etc. are now being configured in the build directory, keeping the src directory clean.
Issue 506 - Addressing comments on previous few commits
Issue 508 -- Implement final bout of structus to read in the 3D mesh
Issue 529 - Fixes the array ordering in the specfem++ arrays
ooof I see there are conflict nowwwwww |
Yay!!! |
Rohit-Kakodkar
approved these changes
Mar 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved! Assuming I saw all previous PRs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implementation of the 3D mesh reader, and associated updates to the codebase.
Main tracking branch: Branch
issue-390
PRs
New implementations
Restructure
Issue Number
For the related issues, please see the PRs
Checklist
Please make sure to check developer documentation on specfem docs.