Skip to content

Conversation

@Rohit-Kakodkar
Copy link
Collaborator

Description

Please describe the changes/features in this pull request.

  • Update index function in edge/intersection iterator
  • Update for_all execution function

Issue Number

If there is an issue created for these changes, link it here

Checklist

Please make sure to check developer documentation on specfem docs.

  • I ran the code through pre-commit to check style
  • THE DOCUMENTATION BUILDS WITHOUT WARNINGS/ERRORS
  • I have added labels to the PR (see right hand side of the PR page)
  • My code passes all the integration tests
  • I have added sufficient unittests to test my changes
  • I have added/updated documentation for the changes I am proposing
  • I have updated CMakeLists to ensure my code builds
  • My code builds across all platforms

- [x] Update index function in edge/intersection iterator
- [x] Update `for_all` execution function
@Rohit-Kakodkar Rohit-Kakodkar added the fix labels a bug fix label Nov 5, 2025
Copy link
Collaborator

@lsawade lsawade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll deal with conflict in 3D

@int-ptr-ptr
Copy link
Collaborator

int-ptr-ptr commented Nov 6, 2025

@Rohit-Kakodkar
the failed NVIDIA check is the same error I've encountered.

CMake Error at tests/unit-tests/data/dim2/ncmarked_conforming_grid_flat/provenance/CMakeLists.txt:4 (configure_file):

  No such file or directory

Since it can't find the file in a relative path, I set them to absolutes in #1339, which should be a proper fix (at least, I haven't had any issues since).

Edit: nevermind, ncmarked_conforming_grid_flat is the one that you did not add the if(SPECFEMPP_CONFIGURE_TEST) fix to, so your fix might be it. I do both the if statement and absolute-path-inputs in #1339, which we can revert the latter if you don't like it.

@Rohit-Kakodkar Rohit-Kakodkar merged commit 75a442e into devel Nov 8, 2025
8 checks passed
@Rohit-Kakodkar Rohit-Kakodkar deleted the issue-1350 branch November 8, 2025 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix labels a bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants