Skip to content

Conversation

@Rohit-Kakodkar
Copy link
Collaborator

Description

  • Adds a macros library in core
  • Moves all macros from enumerations, macros to this library
  • Removes __future__

If there is an issue created for these changes, link it here

Checklist

Please make sure to check developer documentation on specfem docs.

  • I ran the code through pre-commit to check style
  • THE DOCUMENTATION BUILDS WITHOUT WARNINGS/ERRORS
  • I have added labels to the PR (see right hand side of the PR page)
  • My code passes all the integration tests
  • I have added sufficient unittests to test my changes
  • I have added/updated documentation for the changes I am proposing
  • I have updated CMakeLists to ensure my code builds
  • My code builds across all platforms

- [x] Adds a macros library in core
- [x] Moves all macros from enumerations, macros to this library
- [x] Removes `__future__`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants