1178 - Update snakefile for all database in test data #1358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
int-ptr-ptr
approved these changes
Nov 7, 2025
Comment on lines
+16
to
+17
| pathvars: | ||
| cwd=f"dim2/{db_name}" |
Collaborator
There was a problem hiding this comment.
I tried running this snakemake workflow. I get the following error
SyntaxError in file "/Users/rohit-kakodkar/Desktop/SPECFEMPP/tests/unit-tests/data/Snakefile", line 10:
Unexpected keyword pathvars in module definition:
None
Collaborator
Author
There was a problem hiding this comment.
It could be a version issue, I've updated snakemake version to 9.13.4 in the latest PR.
Collaborator
There was a problem hiding this comment.
Can you add a snakemake min version requirement in the files that use pathvars.
from snakemake.utils import min_version
min_version("9.13")
Collaborator
|
Btw, I love how short the snake files are |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use snakemake to generate database.bin in tests/unit-tests/data
Issue Number
Adds to #1178
Checklist
Please make sure to check developer documentation on specfem docs.