Skip to content

Conversation

@icui
Copy link
Collaborator

@icui icui commented Nov 6, 2025

Description

  • Add a new HomogeneousAcousticDomainCompositeStaceyDirichletBC since the old provenance is missing
  • Add workflow for database.bin for Cosserat domain
  • For now I'm not adding finite difference trace to the workflow because it is CUDA only
  • Re-generate all database.bin with updated format (deleting the write_adjacency_map line)

Issue Number

Closes #1178

Checklist

Please make sure to check developer documentation on specfem docs.

  • I ran the code through pre-commit to check style
  • THE DOCUMENTATION BUILDS WITHOUT WARNINGS/ERRORS
  • I have added labels to the PR (see right hand side of the PR page)
  • My code passes all the integration tests
  • I have added sufficient unittests to test my changes
  • I have added/updated documentation for the changes I am proposing
  • I have updated CMakeLists to ensure my code builds
  • My code builds across all platforms

Copy link
Collaborator

@int-ptr-ptr int-ptr-ptr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense, but I might need to see it in action.

Thank you!

return empty_graph;
}

specfem::mesh::adjacency_graph<specfem::dimension::type::dim2> graph(nspec);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forsee issues where someone would want to use a specfem2d database and miss any documentation saying you can't do that. It may not be necessary at the moment, but would it be beneficial to have a more verbose fail message, here?

If this was not the end of specfem2d database, then such a check would require a fiducial bitstring or something of the sort, which may not be worth it. But, since a specfem2d database should give an EOF here, while a specfempp database would keep going, I think it would be better to keep the try-catch on fortran_read_line, but throw another std::runtime_error("unexpected EOF: make sure the database is generated with the SPECFEM++ meshfem2D code").

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants