-
Notifications
You must be signed in to change notification settings - Fork 17
1178 final - finalize displacement tests #1359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 1178-data
Are you sure you want to change the base?
Conversation
int-ptr-ptr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this makes sense, but I might need to see it in action.
Thank you!
| return empty_graph; | ||
| } | ||
|
|
||
| specfem::mesh::adjacency_graph<specfem::dimension::type::dim2> graph(nspec); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forsee issues where someone would want to use a specfem2d database and miss any documentation saying you can't do that. It may not be necessary at the moment, but would it be beneficial to have a more verbose fail message, here?
If this was not the end of specfem2d database, then such a check would require a fiducial bitstring or something of the sort, which may not be worth it. But, since a specfem2d database should give an EOF here, while a specfempp database would keep going, I think it would be better to keep the try-catch on fortran_read_line, but throw another std::runtime_error("unexpected EOF: make sure the database is generated with the SPECFEM++ meshfem2D code").
Description
HomogeneousAcousticDomainCompositeStaceyDirichletBCsince the old provenance is missingdatabase.binfor Cosserat domaindatabase.binwith updated format (deleting thewrite_adjacency_mapline)Issue Number
Closes #1178
Checklist
Please make sure to check developer documentation on specfem docs.