Issue 1591 - Maxwell Solid, Nelder-Mead-Algorithm, tau_epsilon computation#1615
Open
Issue 1591 - Maxwell Solid, Nelder-Mead-Algorithm, tau_epsilon computation#1615
Conversation
… algorithm. Associated tests as well.
lsawade
added
the
new physics
icui
approved these changes
Jan 30, 2026
Collaborator
Author
|
Refactored the optimization interface. If we want to swap it out for something else it should be simple. |
icui
requested changes
Feb 4, 2026
Rohit-Kakodkar
approved these changes
Feb 5, 2026
Collaborator
Rohit-Kakodkar
left a comment
Rohit-Kakodkar
left a comment
There was a problem hiding this comment.
Looks good. Minor change regarding docs.
core/specfem/attenuation/maxwell.hpp
Outdated
Comment on lines
46
to
52
| * \f[A(\omega) = \frac{1}{L} \sum_{i=1}^{L} \frac{1 + \omega^2 \tau_{\epsilon_i} \tau_{\sigma_i}}{1 + \omega^2 \tau_{\sigma_i}^2}\f] | ||
| * | ||
| * \f[B(\omega) = \frac{1}{L} \sum_{i=1}^{L} \frac{\omega (\tau_{\epsilon_i} - \tau_{\sigma_i})}{1 + \omega^2 \tau_{\sigma_i}^2}\f] | ||
| * | ||
| * where \f$L = N_\text{SLS}\f$. At low frequency, \f$A\f$ approaches \f$1\f$. The quality factor \f$Q = A/B\f$ is independent of the normalization. | ||
| * \f$B\f$ is independent of the normalization. | ||
| * |
Collaborator
There was a problem hiding this comment.
There are some locations where the linter seems to have not run
core/specfem/optimization.hpp
Outdated
| #include <Kokkos_Core.hpp> | ||
|
|
||
| /** | ||
| * @namespace specfem::optimization |
Collaborator
There was a problem hiding this comment.
This doc string is in the wrong place
Collaborator
Author
There was a problem hiding this comment.
My pre-commit hook isn't working...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the computation of tau_epsilon in the fortran form. Tests check whether we are below accuracy thresholds given by Savage 2010.
For specific combinations of bands and standard linear solids.
Commits
Issue Number
Closes #1591
Checklist
Please make sure to check developer documentation on specfem docs.