Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V0.2.0 preparation / Utoipa v5 support #45

Merged
merged 14 commits into from
Oct 17, 2024
Merged

V0.2.0 preparation / Utoipa v5 support #45

merged 14 commits into from
Oct 17, 2024

Conversation

DenuxPlays
Copy link
Collaborator

@DenuxPlays DenuxPlays commented Oct 2, 2024

The main goal is to get 100% compatible with utoipa v5.
closes: #44

TODOs

  • add/complete the changelog
  • add more acceptance tests
  • fix tests
  • remove generic schema discovery
  • update documentation

Changelog

Breaking

  • updated msrv to 1.75.0
  • removed generic_full_path feature

Added

  • generics acceptance tests
  • responses acceptance tests

Changes

  • added generic acceptance tests
  • added responses acceptance tests
  • updated test to utoipa v5

Removed

  • removed Generic Schema support (as this is handled by utoipa now)

preparation for v0.2.0 as we have to rework the whole generic feature
Note: for now as we will create new ones when the core is restructured
@DenuxPlays
Copy link
Collaborator Author

Test fail because the ToSchema derive is broken for constant generics:
juhaku/utoipa#1115

@DenuxPlays
Copy link
Collaborator Author

Still some weird things that needs investigating:

Without the new schema_discovery feature there are routes missing?
Still no schemas are auto-discovered by utoipa (I guess this has something to do with the other issue mentioned above)

@DenuxPlays
Copy link
Collaborator Author

As long as responses (including their schemas) are not being auto-discovered we cannot remove schema discovery/put it behind a feature flag.
Related issue: juhaku/utoipa#1094

This will not stop or impact the development just a note.

@DenuxPlays DenuxPlays marked this pull request as ready for review October 14, 2024 20:00
@DenuxPlays
Copy link
Collaborator Author

@ProbablyClem I think this is ready.

Can you please take a look at it.

@DenuxPlays DenuxPlays changed the title V0.2.0 preparation V0.2.0 preparation / Utoipa v5 support Oct 14, 2024
Copy link
Owner

@ProbablyClem ProbablyClem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR thanks :

@DenuxPlays
Copy link
Collaborator Author

Thank you :)

I would merge this pr.
Can you create a new release then?

@DenuxPlays DenuxPlays merged commit 7469f9d into main Oct 17, 2024
7 checks passed
@DenuxPlays DenuxPlays deleted the feature/utoipa-v5 branch October 17, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version 0.2.0 (For utoipa v5)
2 participants