Review fixes #11
Open
Review fixes #11
+819
−243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Test on Playground |
There was a problem hiding this comment.
Pull Request Overview
This PR updates the plugin's text domain from 'color-scheme' to 'brand-assets' and refactors the settings page to use structured helper methods, replacing the custom CSS option with a comprehensive set of popover styling controls.
- Updated all internationalization strings to use the correct 'brand-assets' text domain
- Refactored settings page to use reusable rendering methods for form fields
- Replaced the "custom CSS" loading mode with individual popover styling options using CSS custom properties
- Extracted inline JavaScript to separate files for better maintainability
- Changed pattern file from
.incto.phpand updated loading mechanism
Reviewed Changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/edit.js | Updated text domain from 'color-scheme' to 'brand-assets' and added eslint-disable comments for console.log statements |
| readme.txt | Updated documentation to remove custom CSS option and reference new filter-based customization approach |
| phpcs.xml | Excluded long closure rules to accommodate refactored code |
| package-lock.json | Updated dependency versions (caniuse-lite, fsevents) |
| includes/class-brand-assets.php | Changed pattern file extension from .inc to .php and updated file loading from file_get_contents to require |
| includes/class-brand-assets-settings.php | Major refactor: added helper methods for rendering form fields, replaced custom CSS with structured styling options, and extracted JavaScript to external file |
| includes/class-brand-assets-options.php | Added default values for popover styling options and removed 'custom' CSS mode |
| includes/class-brand-assets-frontend.php | Refactored CSS loading to generate CSS custom properties from user settings and extracted copy color script to external file |
| includes/brand-page-pattern.php | Added PHP opening tag, file header, and heredoc syntax for pattern content |
| build/index.js | Minified build output reflecting text domain changes |
| build/index.asset.php | Updated build version hash |
| assets/frontend.css | Replaced hardcoded styles with CSS custom properties for user customization |
| assets/copy-color.js | New file: extracted copy-to-clipboard functionality from inline script |
| assets/admin.js | New file: admin settings page JavaScript for color picker and styling section toggle |
| README.md | Updated documentation to reflect new styling options and filter-based customization approach |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
ilicfilip
reviewed
Oct 29, 2025
Contributor
ilicfilip
left a comment
ilicfilip
left a comment
There was a problem hiding this comment.
Do we want to add Contributors to the readme.txt?
Everything else looks good
Member
Yes we should - add the three of us + the progressplanner user |
Member
Author
|
Added 👍 |
Member
Author
|
Ran the Plugin Review plugin to verify the fixes and got another issue reported, fixed in fc082bb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.