Fix global (block) "Show CMYK" setting #9
+190
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Sculptor <[email protected]>
Contributor
|
Test on Playground |
Member
|
Tried this on progressplanner.com and had to run the attempt recovery, so don't think the migration works. Other than that it works though! |
Contributor
Author
|
works better if build is actually ran 🤦 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue with color not being displayed in the CMYK format, although the "Show CMYK values" toggle was ON.
The problem was that in the part of the code showCMYK was checked as it was swatch (not block) setting.
Since this change also changes the HTML the block outputs Gutenberg complained with
This block contains unexpected or invalid content - Attempt Recoveryerror. Recovery worked, but since it isn't user friendly this PR also adds migration, from old to new format, so the upgrade is smooth.