Skip to content

Conversation

@aristath
Copy link
Member

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds multiple bypass methods to disable WordPress XML-RPC functionality, building upon the existing filter-based approach with additional layers of protection.

  • Introduces a custom empty XML-RPC server class to replace the default WordPress implementation
  • Adds early termination for XML-RPC requests during initialization
  • Provides multiple defensive layers against XML-RPC access attempts

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

@ilicfilip ilicfilip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aristath , it's nitpicking but I think we should either return error in both places (serve_request and init hook) or empty response (not mixed).

I added helper function which returns the error in the XML format (since that is the format used by XMLRPC) and used it in both places, revert the commit if you dont like it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants