-
Notifications
You must be signed in to change notification settings - Fork 0
Add more bypass methods #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds multiple bypass methods to disable WordPress XML-RPC functionality, building upon the existing filter-based approach with additional layers of protection.
- Introduces a custom empty XML-RPC server class to replace the default WordPress implementation
- Adds early termination for XML-RPC requests during initialization
- Provides multiple defensive layers against XML-RPC access attempts
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
ilicfilip
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aristath , it's nitpicking but I think we should either return error in both places (serve_request and init hook) or empty response (not mixed).
I added helper function which returns the error in the XML format (since that is the format used by XMLRPC) and used it in both places, revert the commit if you dont like it.
This reverts commit e07a3b7.
No description provided.