Bug/issue 1026 deeply nested direct hash links #1028
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
resolves #1026
Summary of Changes
loadRoute
async
to account for loading content before trying to change a hash (race condition)staticRouter
as experimental in the Configuration docsTODO
ChromeSafariFirefoxpathname
,hash
, etc) throughpushState
in one go?RouteComponent
?loadRoute
take a callback?Test Cases
->
- click menu>
- expand menuHome -> Plugins + side nav ✅
Home -> Getting Started + side nav + nested items ✅
Home -> Getting Started + side nav + nested items ✅ *
Note: when going back, Key Concept and Project Setup should not be visited.
Home -> Getting Started + side nav + nested items -> Blog ✅
Home -> Getting Started + side nav + nested items -> Blog ✅
Note: when going back, Key Concept and Project Setup should not be visited.
Docs -> About + side nav ✅