Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug/issue 165 no premature double custom element instantiation in renderFromHTML #166

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

thescientist13
Copy link
Member

Related Issue

resolves #165

Summary of Changes

  1. Reduce double instantiation in renderFromHTML
  2. Add test case

@thescientist13 thescientist13 added the bug Something isn't working label Oct 1, 2024
@thescientist13 thescientist13 changed the title refactor custom element instantiation for renderFromHTML bug/issue 165 no premature double instantiation in renderFromHTML Oct 1, 2024
@thescientist13 thescientist13 changed the title bug/issue 165 no premature double instantiation in renderFromHTML bug/issue 165 no premature double custom element instantiation in renderFromHTML Oct 1, 2024
@thescientist13 thescientist13 merged commit 21b4850 into master Oct 18, 2024
12 checks passed
@thescientist13 thescientist13 deleted the bug/issue-165-undefined-top-level-attributes branch October 18, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

top level attributes returning as undefined
1 participant