enhancement/Issue-99: Refactor keyframes to be a transition #109
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Fix #99
Summary of Changes
Details
With keyframes it's a linear start-to-finish type animation. Our issue was that when the page/element loads, the animation starts. And in this case, would play the
backwards
animation which must first display the "finish" state and animate back to the "start".With the
transition
property, we can set various states which are unaware of specific place in a linear timeline and the transition between them is seamless. So, we set the "has" state, and "not-has" state individually. When either of these states is changed, the browser will transition the property to the active state.Screen.Recording.2024-10-12.at.23.07.17.mov