Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement/Issue-99: Refactor keyframes to be a transition #109

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

DevLab2425
Copy link
Contributor

@DevLab2425 DevLab2425 commented Oct 13, 2024

Related Issue

Fix #99

Summary of Changes

  • Remove styles keyframes and replace with transition for popover indicators
    • Guides
    • Table of Contents

Details

With keyframes it's a linear start-to-finish type animation. Our issue was that when the page/element loads, the animation starts. And in this case, would play the backwards animation which must first display the "finish" state and animate back to the "start".

With the transition property, we can set various states which are unaware of specific place in a linear timeline and the transition between them is seamless. So, we set the "has" state, and "not-has" state individually. When either of these states is changed, the browser will transition the property to the active state.

Screen.Recording.2024-10-12.at.23.07.17.mov

Copy link

netlify bot commented Oct 13, 2024

Deploy Preview for super-tapioca-5987ce ready!

Name Link
🔨 Latest commit aed409e
🔍 Latest deploy log https://app.netlify.com/sites/super-tapioca-5987ce/deploys/670b3a9081413400087e356e
😎 Deploy Preview https://deploy-preview-109--super-tapioca-5987ce.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@DevLab2425 DevLab2425 marked this pull request as ready for review October 13, 2024 02:49
@thescientist13 thescientist13 added the enhancement New feature or request label Oct 14, 2024
Copy link
Member

@thescientist13 thescientist13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks and really appreciate the breakdown of what was happening as well as the solution. 🙇‍♂️

I will give it a couple days for other folks to review otherwise we can plan to merge this after our weekly meeting this week.

@DevLab2425 DevLab2425 added the hacktoberfest-accepted Used to participate in Hacktoberfest label Oct 14, 2024
@thescientist13 thescientist13 changed the title Issue-99: Refactor keyframes to be a transition enhancement/Issue-99: Refactor keyframes to be a transition Oct 17, 2024
@thescientist13 thescientist13 merged commit 8f68459 into main Oct 17, 2024
5 checks passed
@thescientist13 thescientist13 deleted the issue-99-rotate-menu-indicator branch October 17, 2024 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest-accepted Used to participate in Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

animate mobile dropdown menu indicate back up on close
2 participants