Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement/issue 30 above the fold home page feedback #124

Merged
merged 7 commits into from
Nov 7, 2024

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Oct 30, 2024

Related Issue

#30

Summary of Changes

Applying home page feedback from latest team meeting

  1. Max out heading logo width at bigger breakpoints
  2. Better center hero banner container
  3. Tweak vertical alignment of npx CTA
  4. Tweak font sizes for capabilities section content
  5. Align entire home page "gutter"

TODO

  1. final internal feedback - enhancement/issue 30 above the fold home page feedback #124 (review)

@thescientist13 thescientist13 added the enhancement New feature or request label Oct 30, 2024
@thescientist13 thescientist13 linked an issue Oct 30, 2024 that may be closed by this pull request
7 tasks
Copy link

netlify bot commented Oct 30, 2024

Deploy Preview for super-tapioca-5987ce ready!

Name Link
🔨 Latest commit 634278f
🔍 Latest deploy log https://app.netlify.com/sites/super-tapioca-5987ce/deploys/672c0c34fe18ba0008df6c34
😎 Deploy Preview https://deploy-preview-124--super-tapioca-5987ce.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@thescientist13 thescientist13 changed the title Enhancement/above the fold home page feedback enhancement/above the fold home page feedback Oct 30, 2024
@thescientist13 thescientist13 changed the title enhancement/above the fold home page feedback enhancement/issue 30 above the fold home page feedback Oct 30, 2024
Copy link
Member Author

@thescientist13 thescientist13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some good feedback from the call tonight

  1. Left justify all content rows, e.g. the Go from zero... section should be flush with the edges of the hero banner (and keep that consistent the whole length of the page)
    Screenshot 2024-10-30 at 7 46 32 PM
  2. Trim the top / bottom margins or paddings from the social tray
    Screenshot 2024-10-30 at 7 56 09 PM

@thescientist13 thescientist13 force-pushed the enhancement/above-the-fold-home-page-feedback branch from f4c7f09 to 13f357d Compare November 4, 2024 17:15
@thescientist13 thescientist13 force-pushed the enhancement/above-the-fold-home-page-feedback branch from ffd546f to 634278f Compare November 7, 2024 00:39
@thescientist13 thescientist13 merged commit e16415a into main Nov 7, 2024
5 checks passed
@thescientist13 thescientist13 deleted the enhancement/above-the-fold-home-page-feedback branch November 7, 2024 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

Home Page
1 participant