feature/issue 34 blog landing page and all posts #84

thescientist13 · 2024-08-27T01:53:40Z

Related Issue

resolves #34 / #35

Summary of Changes

Pull in all current blog content from the current website
Leverage new content as to data to render blog posts landing page w/
- (optional) coverImage frontmatter (optional)
- published frontmatter and used for sorting
- (optional) abstract frontmatter
Pull over styles and images and align with current designs

TODO

build is broken

    TypeError [ERR_INVALID_URL]: Invalid URL
         at new NodeError (node:internal/errors:405:5)
         at new URL (node:internal/url:676:13)
         at Object.enter (file:///Users/owenbuckley/Workspace/project-evergreen/www.greenwoodjs.dev/node_modules/@greenwood/cli/src/plugins/resource/plugin-standard-css.js:55:13)
         at walkNode (file:///Users/owenbuckley/Workspace/project-evergreen/www.greenwoodjs.dev/node_modules/css-tree/lib/walker/create.js:169:36)
         at List.walkReducer (file:///Users/owenbuckley/Workspace/project-evergreen/www.greenwoodjs.dev/node_modules/css-tree/lib/walker/create.js:195:61)
         at List.reduce (file:///Users/owenbuckley/Workspace/project-evergreen/www.greenwoodjs.dev/node_modules/css-tree/lib/utils/List.js:174:22)
         at Object.Value (file:///Users/owenbuckley/Workspace/project-evergreen/www.greenwoodjs.dev/node_modules/css-tree/lib/walker/create.js:103:31)
         at walkNode (file:///Users/owenbuckley/Workspace/project-evergreen/www.greenwoodjs.dev/node_modules/css-tree/lib/walker/create.js:180:41)
         at Object.Declaration (file:///Users/owenbuckley/Workspace/project-evergreen/www.greenwoodjs.dev/node_modules/css-tree/lib/walker/create.js:108:28)
         at walkNode (file:///Users/owenbuckley/Workspace/project-evergreen/www.greenwoodjs.dev/node_modules/css-tree/lib/walker/create.js:180:41) {
       input: './assets/link.svg',
       code: 'ERR_INVALID_URL'
     }

how is activeFrontmatter working? 🤔
check all posts for correct images / styles / etc
Final responsiveness + browser checking / styling tweaks
~~(new issue / nice to have) sticky footer - footer doesn't touch the bottom on desktop blog landing page~~ - with the cards, the page is long enough, so no worries for now 😮‍💨
first round internal feedback - feature/issue 34 blog landing page and all posts #84 (comment)

Upstreams

Greenwood doesn't seen to hot reload graph data on frontmatter changes , and also rebuilding any content as data consumers (not sure if already tracking this) - support hot reloading content as data changes during development greenwood#1278
(tracked) Content as Data greenwood#1167
(tracked) import map merging not working? - rfc/issue 1167 content as data greenwood#1266
(tracked) need to patch userWorkspace in SSR context? - provide initialized compilation to custom loader script (and resource plugins) greenwood#1273

Thoughts / Observations

thoughts on block quote styling? - seems fine for now, can / will revisit as part of docs / guides
should all (non <h1>) headings have a link? - yes
(new issue) small caveat around positioning link headings - "deep link" headings and icon enhancements #89
- https://github.com/ProjectEvergreen/www.greenwoodjs.dev/pull/84/files#diff-8231af1f5742ecbdbdda65059cb3effba83956b69f034e6551c55efbc3996355
(new issue) content as data for - leverage content as data for the header component navigation content #88
- header
- latest post
(new issue) glitchy header link rollovers (FF / Safari) - header navigation rollover is glitchy in Safari / FF #90

netlify · 2024-08-27T01:54:15Z

✅ Deploy Preview for super-tapioca-5987ce ready!

Name	Link
🔨 Latest commit
🔍 Latest deploy log	https://app.netlify.com/sites/super-tapioca-5987ce/deploys/66d62be86f15575dfad7e35a
😎 Deploy Preview	https://deploy-preview-84--super-tapioca-5987ce.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

thescientist13 · 2024-08-28T23:38:44Z

src/pages/blog/index.html

+        margin: var(--size-2);
+      }
+
+      .heading {


Good call out from @aholtzman
From the designs, we need to make this text a lot bigger and with the "pyramid" style of the news and text (e.g. the line break)

thescientist13 · 2024-08-28T23:43:56Z

src/components/blog-posts-list/blog-posts-list.js

+              coverImage && coverImage !== "/assets/greenwood-logo-g.svg" ? "4px" : "14px";
+
+            return `
+              <li class="${styles.postsListItem}">


@aholtzman observed that the designs promote a more tradition card layout, where in the whole card should probably be wrapped in a link / clickable, and then we should match the heading and body text color / etc accordingly to match

And we should also try and keep the rounded corners to similar ratios / degrees, so rounding off the image instead of a circle (and then play around with the padding / spacing a bit)

thescientist13 · 2024-08-28T23:58:56Z

src/styles/theme.css

@@ -70,3 +70,15 @@ app-header {
  display: block;
  margin: 10px 0 0;
 }
+
+h2 > a > span.icon {


for deep link headings, convention seems to be

Show on hover

(optionally) move it to the right

freshen up the link SVG we're using?

thescientist13 · 2024-09-02T15:55:34Z

First round internal feedback

page heading - feature/issue 34 blog landing page and all posts #84 (comment)
card layout - feature/issue 34 blog landing page and all posts #84 (comment)
deep link heading styles - feature/issue 34 blog landing page and all posts #84 (comment)

thescientist13 added 6 commits August 26, 2024 14:14

initial lift and shift of blog landing page and posts content and styles

2b96642

link headings for blog posts

ad9e8c9

active frontmatter title content

ac38db1

styling blog post landing page cards

cc0c5cc

add blog post abstracts

bbc88d9

sort blog posts list in reverse chronological order

c4842ad

thescientist13 added enhancement New feature or request needs upstream Notes that this item exposes an issue with a dependency (usually Greenwood) content Non Greenwood specific content like home page copy text, blog posts, etc labels Aug 27, 2024

thescientist13 self-assigned this Aug 27, 2024

thescientist13 linked an issue Aug 27, 2024 that may be closed by this pull request

Blog Post Details Page #35

Closed

6 tasks

thescientist13 added 2 commits August 26, 2024 22:09

relative path for link heading svg icon

cbea964

patch SSR context for output and workspace dirs

404415f

thescientist13 added the question Further information is requested label Aug 27, 2024

thescientist13 changed the title ~~feature/issue 34 blog landing and all posts~~ feature/issue 34 blog landing page and all posts Aug 27, 2024

thescientist13 mentioned this pull request Aug 28, 2024

rfc/issue 1167 content as data ProjectEvergreen/greenwood#1266

Merged

31 tasks

thescientist13 added 5 commits August 27, 2024 20:18

patch checking for activeFrontmatter first for page title

5474aeb

enable active frontmatter

b2c6359

pull over all post images and style tweaks

036aba2

namespace blog page styles

9afa01a

formatting

8d5a866

thescientist13 mentioned this pull request Aug 28, 2024

feature/issue 1268 import map and attribute polyfill configuration ProjectEvergreen/greenwood#1269

Merged

12 tasks

thescientist13 added 4 commits August 27, 2024 21:16

apply lighthouse feedback

e04fc13

mobile responsive styling

b294142

namespace page content in app layout

0edb78b

update home page link to v0.29.0 post release

5ef6144

thescientist13 marked this pull request as ready for review August 28, 2024 01:49

grammar and typos

215b289

thescientist13 commented Aug 28, 2024

View reviewed changes

font bolding and blog card list style internal review feedback

96d0b1f

thescientist13 mentioned this pull request Sep 2, 2024

enhancement/issue 30 apply bold font family to key home page headings #85

Merged

3 tasks

thescientist13 added 2 commits September 2, 2024 13:39

formatting

6d44645

auto link headings styles

8e31d3a

thescientist13 mentioned this pull request Sep 2, 2024

provide initialized compilation to custom loader script (and resource plugins) ProjectEvergreen/greenwood#1273

Closed

patching full compilation support for custom loaders

0e8c2d8

This was referenced Sep 5, 2024

leverage content as data for the header component navigation content #88

Closed

"deep link" headings and icon enhancements #89

Open

thescientist13 merged commit 9031ce6 into main Sep 5, 2024
1 of 5 checks passed

thescientist13 deleted the feature/issue-34-blog-pages branch September 5, 2024 18:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feature/issue 34 blog landing page and all posts #84

feature/issue 34 blog landing page and all posts #84

thescientist13 commented Aug 27, 2024 •

edited

Loading

netlify bot commented Aug 27, 2024 •

edited

Loading

thescientist13 Aug 28, 2024

thescientist13 Aug 28, 2024

thescientist13 Aug 28, 2024

thescientist13 commented Sep 2, 2024 •

edited

Loading

feature/issue 34 blog landing page and all posts #84

feature/issue 34 blog landing page and all posts #84

Conversation

thescientist13 commented Aug 27, 2024 • edited Loading

Related Issue

Summary of Changes

TODO

Upstreams

Thoughts / Observations

netlify bot commented Aug 27, 2024 • edited Loading

✅ Deploy Preview for super-tapioca-5987ce ready!

thescientist13 Aug 28, 2024

Choose a reason for hiding this comment

thescientist13 Aug 28, 2024

Choose a reason for hiding this comment

thescientist13 Aug 28, 2024

Choose a reason for hiding this comment

thescientist13 commented Sep 2, 2024 • edited Loading

thescientist13 commented Aug 27, 2024 •

edited

Loading

netlify bot commented Aug 27, 2024 •

edited

Loading

thescientist13 commented Sep 2, 2024 •

edited

Loading