Skip to content

fix: iOS home element overlapping bundle content in default modal #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 18, 2025

Conversation

vasiliy-pdk
Copy link
Collaborator

Android on the left, iOS on the right

Screenshot 2025-03-18 at 11 05 17

PE-1346

@vasiliy-pdk vasiliy-pdk requested a review from jeremylaw95 March 18, 2025 11:06
Copy link

@jeremylaw95 jeremylaw95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Worth checking a few other sites on iOS to make sure this doesn't negatively affect other integrations, just in case.

Also, does this need fixing on android too? I couldn't quite see from the images whether it was an issue there too

@vasiliy-pdk
Copy link
Collaborator Author

No it doesn't require fixing on Android because the OS UI element is outside of the native app. If it's inside on some versions this changes would shift Bundle up.

@vasiliy-pdk vasiliy-pdk merged commit 8ed64d7 into main Mar 18, 2025
3 checks passed
@vasiliy-pdk vasiliy-pdk deleted the vasyl/fix-iOS-home-element-overlap-PE-1346 branch March 18, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants