fix: iOS home element overlapping bundle content in default modal #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremylaw95
approved these changes
Mar 18, 2025
jeremylaw95
left a comment
jeremylaw95
left a comment
There was a problem hiding this comment.
Looks good! Worth checking a few other sites on iOS to make sure this doesn't negatively affect other integrations, just in case.
Also, does this need fixing on android too? I couldn't quite see from the images whether it was an issue there too
Collaborator
Author
|
No it doesn't require fixing on Android because the OS UI element is outside of the native app. If it's inside on some versions this changes would shift Bundle up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Android on the left, iOS on the right
PE-1346