-
Notifications
You must be signed in to change notification settings - Fork 277
Prepare the introduction of pre-commit CI + repository configuration updates #453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Takishima
merged 13 commits into
ProjectQ-Framework:develop
from
Takishima:feature/pre-commit-ci
Oct 30, 2022
Merged
Prepare the introduction of pre-commit CI + repository configuration updates #453
Takishima
merged 13 commits into
ProjectQ-Framework:develop
from
Takishima:feature/pre-commit-ci
Oct 30, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c46de03
to
02c705e
Compare
Pull Request Test Coverage Report for Build 3357022723
💛 - Coveralls |
andreashehn
approved these changes
Oct 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me.
- Added new pre-commit hooks + codespell + pydocstyle + doc8 + yamllint - Update pre-commit hook versions - Add .yamllint configuration file - Add .codespell.allow file for codespell
f212985
to
5fecde8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare the transition to using pre-commit CI to validate PRs.
pre-commit
from GitHub workflows.travis.yml
file since not needed anymore@andreashehn You might want to look at this diff when doing your review, as the rest of the commits are essentially just cosmetic changes in order to solve formatter/linter warnings.
For convenience, here is a link to the diff for the rest of the commits.