Skip to content

Prepare the introduction of pre-commit CI + repository configuration updates #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Oct 30, 2022

Conversation

Takishima
Copy link
Collaborator

@Takishima Takishima commented Oct 27, 2022

Prepare the transition to using pre-commit CI to validate PRs.

  • Remove pre-commit from GitHub workflows
  • Update pre-commit hook versions
  • Add a few new pre-commit hooks
  • Update clang-tidy workflow to use clang-tidy 14
  • Remove .travis.yml file since not needed anymore
  • Fix linter/formatter warnings

@andreashehn You might want to look at this diff when doing your review, as the rest of the commits are essentially just cosmetic changes in order to solve formatter/linter warnings.

For convenience, here is a link to the diff for the rest of the commits.

@Takishima Takishima force-pushed the feature/pre-commit-ci branch from c46de03 to 02c705e Compare October 27, 2022 15:31
@Takishima Takishima requested a review from andreashehn October 27, 2022 15:37
@coveralls
Copy link

coveralls commented Oct 27, 2022

Pull Request Test Coverage Report for Build 3357022723

  • 33 of 33 (100.0%) changed or added relevant lines in 25 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 3356717161: 0.0%
Covered Lines: 7304
Relevant Lines: 7304

💛 - Coveralls

Copy link
Collaborator

@andreashehn andreashehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

@Takishima Takishima force-pushed the feature/pre-commit-ci branch from f212985 to 5fecde8 Compare October 30, 2022 20:29
@Takishima Takishima merged commit ff757e7 into ProjectQ-Framework:develop Oct 30, 2022
@Takishima Takishima deleted the feature/pre-commit-ci branch October 30, 2022 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants