Add CHECKSEQUENCEVERIFY and OP_CHECKDATASIG support #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
ProtocolCash
commented
Apr 19, 2019
ProtocolCash
commented
- add opcodes to ScriptOpCodes class, opCodeMap, and Map
- add SEQUENCE_LOCKTIME_DISABLE_FLAG, SEQUENCE_LOCKTIME_TYPE_FLAG, and SEQUENCE_LOCKTIME_MASK constants from BIP68 to TransactionInput
- count OP_CHECKDATASIG(VERIFY) as 1 sigop per spec
- remove unneeded params in private executeCheckLockTimeVerify function
- add OP_CHECKDATASIG(VERIFY) handling in the Script class
- add opcodes to ScriptOpCodes class, opCodeMap, and Map - add SEQUENCE_LOCKTIME_DISABLE_FLAG, SEQUENCE_LOCKTIME_TYPE_FLAG, and SEQUENCE_LOCKTIME_MASK constants from BIP68 to TransactionInput - count OP_CHECKDATASIG(VERIFY) as 1 sigop per spec - remove unneeded params in private executeCheckLockTimeVerify function - add OP_CHECKDATASIG(VERIFY) handling in the Script class (needs testing/validation!)
- Add November 2018 hard-fork activation time - Add CHECKDATASIG to VerifyFlags if hard-fork date has past
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.