Replace SetDefaultDllDirectories call with Assembly attribute #114
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
ProtonVPN.Servicesets the DLL import search path toLOAD_LIBRARY_SEARCH_DEFAULT_DIRSusing a P/Invoke call to kernel32.dll. I believe the intention is to prevent DLLs being loaded from PATH?In that case, it is possible to do this with an Assembly attribute instead:
This should be identical in behaviour, since
SafeDirectoriesandLOAD_LIBRARY_SEARCH_DEFAULT_DIRSboth have the value0x1000.The
ProtonVPN.Nativemodule becomes redundant this way, since it only contained the P/Invoke binding. Therefore I have removed it.