Code

Fix/build warnings 2024 09 15#159

Code

Open

brmassa wants to merge 31 commits intoProwlEngine:developmentProwlEngine/Prowl:developmentfrom brmassa:fix/build-warnings-2024-09-15brmassa/Prowl:fix/build-warnings-2024-09-15Copy head branch name to clipboard

+446-407

Commits

Commits on Sep 18, 2024

• refactor: comment out private fields/variables that are not used

  brmassa

  committed
  31eb773

  Copy full SHA for 31eb773

• refactor: comment out private fields that are not used

  brmassa

  committed
  fa94257

  Copy full SHA for fa94257

• fix: check of not null

  brmassa

  committed
  09f0d3f

  Copy full SHA for 09f0d3f

• fix: replace async Task for void for a method that do not use any async internally

  brmassa

  committed
  f8f2ebe

  Copy full SHA for f8f2ebe

• fix: switch for a SceneViewPreferences.Instance.GridType must contain all possibilities

  brmassa

  committed
  f9cdd59

  Copy full SHA for f9cdd59

• fix: public static int OrderlessHash<T> must ensure that T is not null because it will be the index of a dictionary

  brmassa

  committed
  2277029

  Copy full SHA for 2277029

• refactor: optimizing Prowl.Runtime.GUI.Spacing to reuse code

  brmassa

  committed
  90aef82

  Copy full SHA for 90aef82

• fix: assure that the t.Get is not null inside SerializedProperty.Merge

  brmassa

  committed
  191e341

  Copy full SHA for 191e341

• fix: KeyFrame's CompareTo and Equals methods allowing null (it will be dealt internally)

  brmassa

  committed
  aea007d

  Copy full SHA for aea007d

• fix: comment unused field and SceneMeshData.MeshData, that are never used

  brmassa

  committed
  4497acf

  Copy full SHA for 4497acf

• fix: new InspectorWindow.CreateInstanceCustomEditor to optimized and enhance code

  brmassa

  committed
  96f5777

  Copy full SHA for 96f5777

• fix: EngineObject.FindObjectsOfType should never return null

  brmassa

  committed
  3a622ba

  Copy full SHA for 3a622ba

• fix: some arguments passed using refinstead the in used in the signature

  brmassa

  committed
  56e3ef1

  Copy full SHA for 56e3ef1

• fix: use await to wait async method to finish

  brmassa

  committed
  9ac5c96

  Copy full SHA for 9ac5c96

• fix: rename Prowl.Editor.SelectHandler's Equals to EqualsFunc to avoid name conflict

  brmassa

  committed
  194948f

  Copy full SHA for 194948f

• fix: using new and override to avoid conflict with inherited methods

  brmassa

  committed
  0e6c93e

  Copy full SHA for 0e6c93e

• fix: unreachable code in Prowl.Runtime.PhysicsSetting

  brmassa

  committed
  398b8e6

  Copy full SHA for 398b8e6

• fix: variable is assigned but its value is never used

  brmassa

  committed
  571d458

  Copy full SHA for 571d458

• fix: check null before using it

  brmassa

  committed
  3f7fb2c

  Copy full SHA for 3f7fb2c

• refactor: in AssetsBrowserWindow.DrawFileEntry no need to use hasSubset. just check if subAsset is not null

  brmassa

  committed
  3adbc9b

  Copy full SHA for 3adbc9b

• fix: CS8603 check for null before using it

  brmassa

  committed
  d7a54f2

  Copy full SHA for d7a54f2

• fix: several null checks

  brmassa

  committed
  93617ed

  Copy full SHA for 93617ed

• fix: CS8605 checking possible null on casting

  brmassa

  committed
  65d1ffb

  Copy full SHA for 65d1ffb

• fix: call Dispose() directly is obsolete. Using .Destroy()

  brmassa

  committed
  6e6f8fe

  Copy full SHA for 6e6f8fe

• fix: CS8625 assigning null to non-nullable fields. most fixes are just settings them nullable

  brmassa

  committed
  8eb1d48

  Copy full SHA for 8eb1d48

• fix: null checking

  brmassa

  committed
  e302443

  Copy full SHA for e302443

• refactor: readonly on several fields/properties that are never reassigned (typical for collections)

  brmassa

  committed
  aca944c

  Copy full SHA for aca944c

• refactor: some extra fixes

  brmassa

  committed
  792893f

  Copy full SHA for 792893f

• Revert "fix: call Dispose() directly is obsolete. Using .Destroy()"

  Show description for 4c695f1
  brmassa

  committed
  4c695f1

  Copy full SHA for 4c695f1

• fix: reverting replacement of Dispose() to Destroy()

  brmassa

  committed
  100488f

  Copy full SHA for 100488f

Commits on Sep 19, 2024

• Revert "refactor: readonly on several fields/properties that are never reassigned (typical for collections)"

  Show description for 0791469
  brmassa

  committed
  0791469

  Copy full SHA for 0791469