Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse <img> tags for crawling, if the option ParseImageTags is set. #70

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Kleissner
Copy link

Implement the code for #69 Parsing image tags to include them in crawling.
By default the new setting ParseImageTags is set to false, so the current default behavior does not change.

@mna
Copy link
Member

mna commented Oct 27, 2019

Hello Peter,

Thanks for the PR, makes sense and looks good to me, could you just add a unit test that exercises that new feature (w.opts.ParseImageTags set to true, and checking that image source URLs have actually been added to the crawler)?

Thanks,
Martin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants