Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

awais786/typing py38 #393

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

awais786
Copy link

@awais786 awais786 commented May 4, 2020

Set 'typing' package to be installed only on Python 2.7. This fixes the import issue raised in Python 3.7 and 3.8 on using the 'typing' module.

Issue report here with complete information

Type of changes

  • Bug fix
  • New feature
  • Documentation / docstrings
  • Tests
  • Other

Checklist

  • I've run the latest black with default args on new code.
  • I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate.
  • I've added tests for new code.
  • I accept that @willmcgugan may be pedantic in the code review.

Description

Please describe your changes here. If this fixes a bug, please link to the issue, if possible.

@awais786 awais786 force-pushed the awais786/typing-py38 branch from 5f40d89 to 44bc8da Compare May 4, 2020 10:03
…he import issue raised

Python 3.7, on using the 'typing 3.6'.
@awais786 awais786 force-pushed the awais786/typing-py38 branch from e15af1f to 8f0f096 Compare May 4, 2020 10:26
@awais786 awais786 marked this pull request as ready for review May 4, 2020 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant