Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of changes
Checklist
Description
Closes #425
Changes the expected behaviour of
FS.islink
in tests so that is never raisesResourceNotFound
, to be consistent withFS.isfile
andFS.isdir
.Changes the base
FS.islink
implementation to one that usesFS.gettype
to check if the resource type issymlink
.Closes #411
Fixes the behaviour of the following
OSFS
methods so that they work as expected:OSFS.islink(path)
: returnsTrue
on existing path to a symlink,False
otherwiseOSFS.gettype(path)
: returnsResourceType.symlink
is the path maps to a symlink (not the case before)OSFS.getinfo(path)
: works even ifpath
is a dangling symlink (TODO)OSFS.scandir(dir)
: works even ifdir
contains a dangling symlink (TODO)