Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of changes
Checklist
Description
I've been cleaning up the huge mess my personal files have become over the years, and I needed a way to list every file in every archive across all my various drives.
To that end, I'm working on a new walker class that uses https://github.com/althonos/fs.archive to recursively list files contained in nested archives.
I noticed a TODO from @althonos, along with references to a missing
WalkerBase
class, and figured I'd go ahead and implement it, since I was looking around for an abstract base class anyway.I'm keeping this open, since there are a couple of things that still need attention (and some reading into how Python implemented generics):
fs.walk.BoundWalker
is still coupled withfs.walk.Walker
specifically.fs.base.FS:
is still coupled withfs.walk.Walker
specifically.