Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WalkerBase #513

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Add WalkerBase #513

wants to merge 1 commit into from

Conversation

mattalxndr
Copy link

@mattalxndr mattalxndr commented Dec 31, 2021

Type of changes

  • New feature
  • Refactoring

Checklist

  • I've run the latest black with default args on new code.
  • I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate.
  • I've added tests for new code.
  • I accept that @PyFilesystem/maintainers may be pedantic in the code review.

Description

I've been cleaning up the huge mess my personal files have become over the years, and I needed a way to list every file in every archive across all my various drives.

To that end, I'm working on a new walker class that uses https://github.com/althonos/fs.archive to recursively list files contained in nested archives.

I noticed a TODO from @althonos, along with references to a missing WalkerBase class, and figured I'd go ahead and implement it, since I was looking around for an abstract base class anyway.

I'm keeping this open, since there are a couple of things that still need attention (and some reading into how Python implemented generics):

  • fs.walk.BoundWalker is still coupled with fs.walk.Walker specifically.
  • fs.base.FS: is still coupled with fs.walk.Walker specifically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant