Add cache for _find_maturin_project_above #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed my app's launch to take forever (nearly half a minute) with most of time spent in
_find_maturin_project_above
which is called repeatedly for every search path whenever a module is loaded.Adding a cache ensures that search paths aren't analyzed over and over again.
AFAIK using
functools.cache
(added in 3.9) should be okay as this project requires Python 3.9. If compatibility is a concern, one could usefunctools.lru_cache(maxsize=None)
instead.