Replace rustls-pemfile with rustls-pki-types #2895
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e-nomem
commented
Dec 16, 2025
Comment on lines
+423
to
427
| if let Some(root_certs) = ca_certificates()? { | ||
| for cert in root_certs { | ||
| tls_builder.add_root_certificate(native_tls::Certificate::from_der(&cert)?); | ||
| } | ||
| } |
Contributor
Author
There was a problem hiding this comment.
I think we should really be calling tls_builder.disable_built_in_roots(true) in this block. That would match the behavior on the rustls side where we replace the root certs instead of appending to it.
Member
There was a problem hiding this comment.
I guess we can do it in v2.0 to avoid potential breakage.
messense
reviewed
Dec 16, 2025
| # num_prefix unmaintained | ||
| "RUSTSEC-2025-0119", | ||
| # rustls-pemfile unmaintained | ||
| "RUSTSEC-2025-0134", |
Member
There was a problem hiding this comment.
we need to keep this for now because of MSRV limit we can't upgrade cargo-xwin yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recommended replacement for
rustls-pemfileseems to be usingrustls-pki-types, so I did that here