-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CI workflow #10
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
36713ee
Update CI workflow
cjdsellers 05c5027
Adjust MSRV and brew install gettext
cjdsellers ab3f84e
Fix rust version
cjdsellers 583cd87
Adjust gettext dependency install
cjdsellers 2f0c580
Revert redundant gettext install
cjdsellers 0c73cb4
Try aarch64 for macOS runner
cjdsellers f5bac2b
Set `DYLD_LIBRARY_PATH` for macOS
cjdsellers 935da7c
Fix warnings
cjdsellers ce96887
Update python-version list
cjdsellers dbfb7c7
Update python-version list
cjdsellers eb24dda
Update build platforms
cjdsellers 9a38f6f
Revert MSRV to 1.63.0
cjdsellers 69622f3
Merge branch 'main' into main
davidhewitt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,8 +15,8 @@ jobs: | |
| fmt: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - uses: actions/setup-python@v4 | ||
| - uses: actions/checkout@v4 | ||
| - uses: actions/setup-python@v5 | ||
| with: | ||
| python-version: "3.10" | ||
| - run: pip install black==24.10.0 | ||
|
|
@@ -32,7 +32,7 @@ jobs: | |
| clippy: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - uses: actions/checkout@v4 | ||
| - uses: dtolnay/rust-toolchain@stable | ||
| with: | ||
| toolchain: stable | ||
|
|
@@ -53,14 +53,15 @@ jobs: | |
| "3.10", | ||
| "3.11", | ||
| "3.12", | ||
| "3.13", | ||
| "pypy-3.9", | ||
| ] | ||
| platform: | ||
| [ | ||
| { | ||
| os: "macOS-latest", | ||
| python-architecture: "x64", | ||
| rust-target: "x86_64-apple-darwin", | ||
| os: "macos-latest", | ||
| python-architecture: "arm64", | ||
| rust-target: "aarch64-apple-darwin", | ||
| }, | ||
| { | ||
| os: "ubuntu-latest", | ||
|
|
@@ -107,10 +108,10 @@ jobs: | |
| extra_features: "nightly" | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - uses: actions/checkout@v4 | ||
|
|
||
| - name: Set up Python ${{ matrix.python-version }} | ||
| uses: actions/setup-python@v4 | ||
| uses: actions/setup-python@v5 | ||
| with: | ||
| python-version: ${{ matrix.python-version }} | ||
| architecture: ${{ matrix.platform.python-architecture }} | ||
|
|
@@ -153,7 +154,7 @@ jobs: | |
| needs: [fmt] | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - uses: actions/checkout@v4 | ||
| - uses: dtolnay/rust-toolchain@stable | ||
| with: | ||
| toolchain: nightly | ||
|
|
@@ -167,10 +168,10 @@ jobs: | |
| args: --all-features | ||
| env: | ||
| CARGO_INCREMENTAL: 0 | ||
| RUSTFLAGS: "-Zprofile -Ccodegen-units=1 -Cinline-threshold=0 -Clink-dead-code -Coverflow-checks=off" | ||
| RUSTDOCFLAGS: "-Zprofile -Ccodegen-units=1 -Cinline-threshold=0 -Clink-dead-code -Coverflow-checks=off" | ||
| RUSTFLAGS: "-Zprofile -Ccodegen-units=1 -Cllvm-args=--inline-threshold=0 -Clink-dead-code -Coverflow-checks=off" | ||
| RUSTDOCFLAGS: "-Zprofile -Ccodegen-units=1 -Cllvm-args=--inline-threshold=0 -Clink-dead-code -Coverflow-checks=off" | ||
| - uses: actions-rs/[email protected] | ||
| id: coverage | ||
| - uses: codecov/codecov-action@v1 | ||
| - uses: codecov/codecov-action@v4 | ||
| with: | ||
| file: ${{ steps.coverage.outputs.report }} | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can probably update the coverage job to use
cargo-llvm-covand stable Rust (like PyO3 does). Possibly a follow-up?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noted, I think it would be best to align with PyO3's practices. I'd like to take another pass at CI once we get the first release of
pyo3-async-runtimesout the door.